[raft/rid] Extract InsertSubscription and route Create through the store - #1682
Closed
MariemBaccari wants to merge 3 commits into
Closed
MariemBaccari wants to merge 3 commits into
MariemBaccari wants to merge 3 commits into
Conversation
MariemBaccari
force-pushed
the
rid_extract_insert_subscription
branch
6 times, most recently
from
September 8, 2026 13:12
5cf053e to
d496eaf
Compare
MariemBaccari
force-pushed
the
rid_extract_insert_subscription
branch
from
September 15, 2026 08:38
d496eaf to
1bbe0d9
Compare
This was referenced Sep 15, 2026
MariemBaccari
marked this pull request as ready for review
September 15, 2026 14:16
MariemBaccari
force-pushed
the
rid_extract_insert_subscription
branch
9 times, most recently
from
September 23, 2026 09:33
578c78e to
db6b69a
Compare
mickmis
approved these changes
Sep 23, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo minor comments
mickmis
reviewed
Sep 23, 2026
MariemBaccari
force-pushed
the
rid_extract_insert_subscription
branch
3 times, most recently
from
September 24, 2026 15:55
61cf2ef to
1a558de
Compare
MariemBaccari
force-pushed
the
rid_extract_insert_subscription
branch
from
September 25, 2026 09:44
1a558de to
282cb73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts insert subscription business logic.
Implements #1701